Replace tomcat-jdbc with HikariCP
#525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switches the default JDBC connection pool in Grails applications from `tomcat-jdbc` to `HikariCP`.
jdaugherty
approved these changes
Feb 19, 2025
| @@ -54,24 +54,6 @@ default void applyDefaultConfig(DatabaseDriverFeature dbFeature, Map<String, Obj | |||
| config.put(ENVIRONMENTS_KEY + "." + PROD_ENVIRONMENT_KEY + "." + getDbCreateKey(), "none"); | |||
| Optional.ofNullable(dbFeature.getJdbcProdUrl()).ifPresent(url -> config.put(ENVIRONMENTS_KEY + "." + PROD_ENVIRONMENT_KEY + "." + getUrlKey(), url)); | |||
|
|
|||
| addProductionDataSourceProperties(config, "jmxEnabled", true); | |||
There was a problem hiding this comment.
Sane defaults are one of the best features of HikariCP!
jamesfredley
approved these changes
Feb 19, 2025
jamesfredley
added a commit
to grails/grails-profiles
that referenced
this pull request
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In accordance with the decision in the Grails Stewards Meeting 2024-10-10, this PR
switches the default JDBC connection pool in Grails 7 applications from
tomcat-jdbctoHikariCP.Spring HikariCP configuration Properties: https://docs.spring.io/spring-boot/appendix/application-properties/index.html#application-properties.data.spring.datasource.hikari